django-celery-monitor
django-celery-monitor copied to clipboard
Django 2.0 compatibility and improved test coverage
This pull request builds on https://github.com/jezdez/django-celery-monitor/pull/40. However, it was failing some code checks because - I assume - the test coverage was lacking. So here are their changes, some additional CI changes and extra unit tests.
Codecov Report
Merging #60 into master will increase coverage by
7.64%. The diff coverage is100%.
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 72.58% 80.22% +7.64%
==========================================
Files 9 9
Lines 434 435 +1
Branches 54 55 +1
==========================================
+ Hits 315 349 +34
+ Misses 114 73 -41
- Partials 5 13 +8
| Impacted Files | Coverage Δ | |
|---|---|---|
| django_celery_monitor/admin.py | 64.75% <100%> (+11.03%) |
:arrow_up: |
| django_celery_monitor/utils.py | 76.19% <100%> (+11.11%) |
:arrow_up: |
| django_celery_monitor/humanize.py | 54.76% <0%> (+30.95%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 6ec1350...4bde111. Read the comment docs.
All green! I've ensured that everything that @madisvain changed is now covered by tests.
@jezdez Do you think this PR will be ever merged ? I actively support the work of @pieterdd in this PR
@DEKHTIARJonathan Yes, it will be merged once I've done the review, please don't ask questions like that.
@pieterdd : I have the event worker which crashed without any reason without leaving anything on the logs every +/- 24hours. Do you think this could be caused by your modifications ?
I have opened an issue on the official celery repository about this: https://github.com/celery/celery/issues/4623
You mention using v4.2 in the ticket. As far as I know, this is pre-release software.
@pieterdd Can you try rebasing?