django-analytical icon indicating copy to clipboard operation
django-analytical copied to clipboard

Admin integration for Piwik (dashboards)

Open bittner opened this issue 11 years ago • 9 comments

According to Piwik's Best Practice for Integration Plugins we should be adding integration of Piwik dashboards into Django's admin.

NOTE: This is a follow-up enhancement request on issue #35

bittner avatar Jul 09 '14 08:07 bittner

Good point. @bittner are you interested in direct commit access?

jcassee avatar Jul 09 '14 08:07 jcassee

Why? Does this bring any advantages? - I think the 4 eyes principle with pull requests is a good thing.

bittner avatar Jul 09 '14 09:07 bittner

That is true, so I am asking if you are interested in co-maintainership. You would be responsible for checking my pull requests. :-)

"No" is an acceptible answer, of course. :-)

jcassee avatar Jul 09 '14 09:07 jcassee

I've thought about it. I don't want to turn you down. It's just I think that I shouldn't take on responsibility for the success of the django-analytical project, because it's not my baby. (Also, I need to keep focused on django-organice.)

I can of course help you out with reviewing (and accepting) pull requests to make sure there is a continuous flow. But for all cases that are not dead easy to wave through there should be you. Also, for edge cases you should take the final decision.

If that's also your idea of "co-maintainership" then yes, let's go for it.

bittner avatar Jul 11 '14 06:07 bittner

Oh, and if I got it wrong, and it's really just about that you want someone to review your code, then - hey! - of course, no problem! You're not going to pour in tons of code every day, will you? :smirk:

bittner avatar Jul 11 '14 06:07 bittner

Hi Peter, sorry for not replying earlier. As this demonstrates, I also have pretty limited time, though I still intend to keep the project alive. I am looking for something more of a (co-)maintainer, and I completely understand your focus on django-organice (which looks, well, really nice).

jcassee avatar Apr 19 '15 09:04 jcassee

Okay, I agree. After all, the worst thing that can happen is that it turns out my time is as limited as yours. Then pull requests continue to sit there unanswered. :smirk:

Seriously, let's give it a try.

bittner avatar Apr 20 '15 09:04 bittner

Alrighty then! Let's promote you.

jcassee avatar Apr 20 '15 09:04 jcassee

Looks like we can now update the README. And hey, accidentally I'm using Django every day! :smiley:

bittner avatar Apr 20 '15 12:04 bittner