dj-database-url icon indicating copy to clipboard operation
dj-database-url copied to clipboard

Published 20 hours ago • verified publisher icon jazzband

Adding type hints

Open sbdchd opened this issue 5 years ago • 4 comments

I was wondering if you'd be open to adding type hints to the repo?

Otherwise, would it be okay if I added them to https://github.com/python/typeshed/

sbdchd avatar Aug 10 '20 23:08 sbdchd

Hey @sbdchd . Since, you got no reply after 2 years, could you add the types you've setup on kodiak to the typeshed?

If you would prefer, I could do it as well, but since it's your code, I think you should do it. Just let me know!

Thank you!

XF-FW avatar Apr 26 '22 21:04 XF-FW

@XF-FW feel free to do it!

sbdchd avatar Apr 26 '22 22:04 sbdchd

I think with where python is no Adding type hints is a good shout. All the supported python version are now typehint compliant.

mattseymour avatar May 28 '22 20:05 mattseymour

As of earlier today, you can now have typing support for this package, by installing the types-dj-database-url package.

XF-FW avatar May 28 '22 20:05 XF-FW

https://github.com/jazzband/dj-database-url/pull/198 adds in type hints (and mypy checks for them)

palfrey avatar Dec 14 '22 12:12 palfrey

Could you let me know when this gets released, so I can deprecate the types-dj-database-url package from typeshed as per their policy[0] ?

[0] https://github.com/python/typeshed/blob/main/CONTRIBUTING.md#third-party-library-removal-policy

XF-FW avatar Dec 21 '22 11:12 XF-FW

@mattseymour Can we do a new release with this in?

palfrey avatar Feb 20 '23 13:02 palfrey

I will take into doing this shortly

mattseymour avatar Feb 20 '23 13:02 mattseymour