image_processing icon indicating copy to clipboard operation
image_processing copied to clipboard

Published 20 hours ago • verified publisher icon janko

use rot command where possible

Open etherbob opened this issue 1 year ago • 1 comments

The similarity command leaves a line on the side of 90/180/270 rotations. This PR uses the rot command where possible.

resolves #104

etherbob avatar Dec 01 '23 03:12 etherbob

@janko fwiw we've currently got a bunch of environments where we have trouble installing vips (though we use it in prod) and so we have to have conditional code that uses the built in rotate in image_magick envs and crafts a custom rot(90|180|270) command when we have vips. Would be great to be able to remove those workarounds.

etherbob avatar Dec 05 '23 21:12 etherbob

I appreciate the PR, and sorry for the delay 😅 Looks good, I will try to make a release soon 👍🏻

janko avatar Jun 06 '24 10:06 janko