bmotion

bmotion copied to clipboard

With redis enabled, the following line is repeated 52 times during load/rehash:

Warning: bMotion_abstract_add_filter not currently implemented

I haven't been able to understand what is causing this, but below is a sample of some console debug output that might help:

[14:09:57] [14:09:56] (5)bMotion: bMotion_abstract_add (cracker_hats, Ahead hat factor %2, 0) [14:09:57] [14:09:56] (4)bMotion: Result of adding Ahead hat factor %2 to abstract cracker_hats: 0 [14:09:57] [14:09:56] (5)bMotion: bMotion_abstract_save [14:09:57] [14:09:56] (4)bMotion: Not saving abstract cracker_hats as we're using redis [14:09:57] [14:09:56] Warning: bMotion_abstract_add_filter not currently implemented [14:09:57] [14:09:56] Warning: bMotion_abstract_add_filter not currently implemented [14:09:57] [14:09:56] Warning: bMotion_abstract_add_filter not currently implemented [14:09:57] [14:09:56] (5)bMotion: bMotion_abstract_register (cracker_your_hats) [14:09:57] [14:09:56] (2)bMotion: batch-adding to cracker_your_hats [14:09:57] [14:09:56] (5)bMotion: bMotion_abstract_add (cracker_your_hats, You're now wearing %2 hats., 0) [14:09:57] [14:09:56] (4)bMotion: Result of adding You're now wearing %2 hats. to abstract cracker_your_hats: 0

Wish I could understand more and fix it myself but I'm more of a sysadmin than a coder. With that said, thank you for all the work you've put into this, it is still providing enjoyment for people after all these years, and with redis it seems to learn and adapt much faster to channel interaction.

Short answer: that message is a reminder (to myself I guess) that the redis backend support isn't quite complete.

Long answer: bMotion_abstract_add_filter is a function which adds a filter against an abstract, which removes matching items from an abstract and prevents them being readded. At the time I was writing the code, I decided I didn't want to try to figure out how to make the redis code implement that feature, and decided it was low enough priority to leave out for the time being. Instead, because bMotion expects that function to exist I just implemented it as a stub which logs that message.

If you're finding it annoying you can comment out the line which logs the message if you like, a grep for it will show you where :)

I'll leave this issue open as a reminder to myself that I should really finish the redis layer, especially now I know other people are using it!

Glad you're enjoying bMotion!

Thank you for responding so quickly and thoroughly! I did already find the line of code where the putlog is for that function and tried grepping anything and everything I could to see if I could find some sort of correlation (again, non-coder here) that made sense to explain what was going on. I suppose I'll go ahead and comment that out for now then to reduce the noise :)