James Lamb
James Lamb
@guolinke or @shiyu1994 can you please read through the questions here and help resolve this discussion?
/gha run r-valgrind Workflow **R valgrind tests** has been triggered! 🚀 https://github.com/microsoft/LightGBM/actions/runs/2893166788 Status: success ✔️.
LightGBM uses the C++11 standard. Could you explain why it's important for your use case to use `c++latest` instead?
Oh I see. The specific errors you've shared come from `fmt`, a project that LightGBM vendors in as a git submodule. You might try visiting https://github.com/fmtlib/fmt if you'd like to...
> LightGBM doesn't support under `/std:c++latest` I think that's correct. I don't believe any of LightGBM's continuous integration jobs test compiling with MSVC using `/std:c++latest`. Some evidence that the project...
Based on https://github.com/microsoft/LightGBM/pull/5540#issuecomment-1281741251, #5540 replaces this PR. I'm going to close this one.
@shiyu1994 I already put up a pull request yesterday to fix that: https://github.com/microsoft/LightGBM/pull/5485 Please, when you see a CI issue that is unrelated to your changes, first look for an...
@shiyu1994 now that recent CI issues have been addressed, I just pushed https://github.com/microsoft/LightGBM/pull/5486/commits/29d573524a09288620849f427ee663135ca7763b updating this with `master` for you 👋
Thanks for working on this! Re-opening the discussion since you're working on it, and tagging @guolinke and @shiyu1994 to help respond to you when they have time. Please be patient,...
@EdmondElephant Are you still interested in pursuing this? If you tell us you are too busy, or don't respond in the next 2 weeks or so, I'll close this PR...