James Lamb

Results 912 comments of James Lamb

> don't know if it's permitted....for this repo's CI to push to ... a fork Here's one report where someone claims it's possible: https://github.com/actions/checkout/issues/455#issuecomment-1079943559. Using the `pull_request_target` condition. And according...

I did the following this morning to make this more friendly for outside contributors: * replaced "[RFC]" in the title with "[python-package]" * removed label "question" * removed assignees *...

@sagnik1511 yes please! You do not need to ask permission and are welcome to work on any file listed in the description of this issue.

This issue has been open for about 8 months now, so I think it's ok for maintainers to start picking up the work to finish it and not wait any...

I think `compat.py` can be safely ignored for this purpose, since it just includes some try-catched imports for compatibility reasons.

Thanks @makquel ! There is plenty of work left in `basic.py` and `sklearn.py`. But please do not try to add hints for everything in either of those files. If you...

I've added the label `fix`. Please add a labels when you create pull requests here, so your PR will be correctly categorized in the release notes (https://github.com/microsoft/LightGBM/pull/5403#issuecomment-1205602981).

> Are we also adding the `__all__`? I think it's good having both. There is already a `__all__` controlling what happens when you `from lightgbm import *`. https://github.com/microsoft/LightGBM/blob/1b43214f72e2f42c262f0c79eb35cd185a8654af/python-package/lightgbm/__init__.py#L30-L36 Are you...

Ok nice! I hadn't thought of that. Totally support that idea. I think that new public classes and functions are rare enough in this project that the communication benefit of...

Ok thanks all! I'll update the description and convert this from an RFC to a regular maintenance issue, similar to #3756 .