Jim Fisher

Results 118 comments of Jim Fisher

Indeed, if the structure was: ``` table row cell "foo" cell "bar" row cell "baz" cell "qux" ``` Then the copied content with my algorithm would be: ``` row cell...

> ... it would intentionally generate an invalid slate tree which the user could not likely recover from. "Validity" of the tree is not a Slate concept; it depends on...

Well, both Copy methods are lossy. My suggested Copy approach is lossy because it removes some ancestors. But the current Copy approach is lossy because it doesn't distinguish between these...

[Here is a Codepen that shows how to implement the simpler copy-paste logic that I suggested, in general shows how to tailor copy-paste to your needs.](https://codepen.io/jameshfisher/pen/OJgKzOe) This simpler logic seems...

(Author of https://github.com/ianstormtaylor/slate/pull/4578 here) I agree that this is a problem, because it's one that I have as well! I would strongly feel that reverting https://github.com/ianstormtaylor/slate/pull/4578 would be the wrong...

I believe it's a browser bug that causes the bad "click at end of line" behavior. I found a possible fix/workaround: make the text element non-zero-width, e.g. add `padding-right: 0.001em`...

It's certainly a browser bug, because Firefox has different behavior. Using [@AleksandrHovhannisyan's example](https://codesandbox.io/s/slate-reproductions-forked-pc1g9?file=/index.js) on Firefox (v85 on Windows), clicking at the end of the paragraph puts the cursor _outside_ the...

Apart from clicking at the end of the paragraph, the other thing that users try (@AleksandrHovhannisyan could you confirm?) is to hit the right arrow key. Currently, Slate seems to...

> Yup—we ended up implementing your solution in [f1b7d18#diff-98b609559db12cb7cc755fd41741b9c72affed934a10cd75db684d5455f3868cR65](https://github.com/ianstormtaylor/slate/commit/f1b7d18f43913474617df02f747afa0e78154d85#diff-98b609559db12cb7cc755fd41741b9c72affed934a10cd75db684d5455f3868cR65) and #4630 for the time being, and it seems to work well. We had to add a focus ring indicator to...

Hi! Good question. I can see GitHub provides a "latest" link `https://github.com/pusher/cli/releases/latest` which redirects to the web view for the latest release, but that's not really appropriate for your use...