hffix

hffix copied to clipboard

hffix_fields.hpp: Use X macros to simplify and add msg_type enum

2

chris-pattern

some errors

11

1. On Windows, there is no 'ssize_t' type. 2. the 'std::string_view' has no begin and end members. ` void push_back_string(int tag, std::string_view s) { push_back_string(tag, s.begin(), s.end()); }`

jackeykong

Let's rewrite the checks in message_reader::init()

6

1) Strengthen the checks (for example, check that the separating symbol is '=' 2) We will detect invalid messages as soon as possible

Roman-Koshelev

Fix next_message_reader() method

4

According to the comment, the function must return a valid message (although not necessarily complete). This is logical, but not so now. Also, now, in the absence of a valid...

Roman-Koshelev

Error in next_message_reader

2

The line "8=FIX" will not necessarily be the beginning of a new message. For example, you will get "58=FIX arbitrary string". Search correctly for "\18=FIX"

Roman-Koshelev

Support for CMake

1

Define a CMakeLists.txt file such that the hffix library can easily be included as an external project for applications and libraries that use CMake.

rossb34

https://www.internalpointers.com/post/writing-custom-iterators-modern-cpp `std::forward_iterator_tag`?

jamesdbrock

It's likely that this template usage code https://github.com/jamesdbrock/hffix/blob/786519d22acdd017660b8eefc91f226587d1fed6/test/src/reader01.cpp#L40 calls `init` twice now, which would be inefficient, as noted by @mvanslobbe in #32

jamesdbrock

"packed representation"?

1

Can this be described as a "packed representation"? https://www.tweag.io/blog/2017-08-24-linear-types-packed-data/ https://drops.dagstuhl.de/opus/volltexte/2017/7273/

jamesdbrock

link to FIX Session-level Test Cases and Expected Behaviors is dead.

jamesdbrock