zipstorer

zipstorer copied to clipboard

This goes much farther than my first PR, into the realm of breaking changes.

• One class per file
• Make public fields properties
• Do not use Microsoft namespaces!
• C# naming conventions
• Implement async
• Add ExtractToFolder
• Always put Dispose in Finally or using
• Refactor and cleanup
• Closes #39
• Closes #22
• Closes https://github.com/jaime-olivares/zipstorer/issues/37
• Closes #43
• Closes https://github.com/jaime-olivares/zipstorer/issues/48

Now closes #48

Thanks @A9G-Data-Droid, Those are indeed a lot of changes in a single PR, not possible to select individual ones. I will review asap. --Jaime.

Any update on this?

It might be easier to review and merge #50 first, as this one is building upon that same branch.

Any updates? Client is constantly complaining about this. They need to upload files bigger than 4gb. Any help would be truly appreciated!

Have you tested my branch? You can review the code yourself and use my version until this is accepted.

I am sorry. I cannot accept this PR, for the following reasons:

• It covers too many aspects at a time.
• It changes the structure of the source code files (it was a one-filer)
• It changes the namespace, breaking all code from existing users
• It removes the build of other platforms than .net standard 2.0, that many users may be using
• Hard to track changes as too many files are renamed/relocated