Jacob Perron

Results 63 issues of Jacob Perron

## Feature request #### Feature description Currently, the client libraries are responsible for generating UUIDs for action goal IDs when an action client makes a request. The goal ID is...

enhancement
backlog

## Feature request #### Feature description `launch_testing` provides several utilities for checking and waiting on process output, e.g. https://github.com/ros2/launch/blob/9e517a3abd016367244fff9fa96ac8eae371a00b/launch_testing/launch_testing/asserts/assert_output.py https://github.com/ros2/launch/blob/9e517a3abd016367244fff9fa96ac8eae371a00b/launch_testing/launch_testing/event_handlers/stdout_ready_listener.py It would be nice if we had similar facilities with...

enhancement
backlog

## Feature request Follow-up to https://github.com/ros2/launch/issues/104#issuecomment-424860566, it would be nice if launch supported stripping color escape sequences when logging output to a file. #### Feature description For example, the following...

enhancement
help wanted

## Feature request #### Feature description When passing a command to `ExecuteProcess`, it would be nice if empty strings were filtered out and not passed to the executable. For example,...

enhancement
help wanted

Similar to topics and services, it would be nice to also support ROS actions. Since actions are built upon topics and services, the bridge implementation will depend on how we...

enhancement

Follow up to #10. We can now bridge services, but it requires manually configuration due to needed typesupport information at compile-time. In order to support bridging services dynamically, we need...

enhancement

Changes to supporting building on Windows (3aa08a8). - Add missing visibility macros, including CMake target definition - Fix build error passing std::filesystem::path instead of std::string - Fix linker error building...

I don't think the `domain_bridge` package currently builds on Windows. We should resolve these build issues. It would also be nice to enable Windows CI via the GitHub workflow. If...

enhancement

Depends on https://github.com/ros2/pybind11_vendor/pull/8 This PR reverts #538, removing a workaround for Windows that should no longer be needed (284134e). pybind11 v2.6.0 introduced a CMake warning if `PYTHON_VERSION` is set: https://github.com/pybind/pybind11/blob/4d037439ba0c7aa9add3c58b4754b634d55203df/tools/pybind11Tools.cmake/#L15-L19...

## Description The `BaseWriterInterface` declares a [`close()` method](https://github.com/ros2/rosbag2/blob/e6867e7a488815665112c556c92cf970bffa2464/rosbag2_cpp/include/rosbag2_cpp/writer_interfaces/base_writer_interface.hpp#L41) that all writer implementations must override. However, the top-level [`Writer` class](https://github.com/ros2/rosbag2/blob/e6867e7a488815665112c556c92cf970bffa2464/rosbag2_cpp/src/rosbag2_cpp/writer.cpp) does not call this anywhere. I'm not sure if this is...

enhancement