jmonkeyengine icon indicating copy to clipboard operation
jmonkeyengine copied to clipboard

Better implementation of the AnimationMask interface

Open capdevon opened this issue 3 years ago • 2 comments

  • Homogeneous signature of methods.
  • Possibility of chaining methods.
  • The 'Armature' is passed only once in the constructor.
  • 'Joints' are passed to methods as strings instead of objects.

capdevon avatar Jun 27 '22 08:06 capdevon

Any feedback on this proposal? Can it be useful or should I close it?

capdevon avatar Jul 26 '22 18:07 capdevon

I think it's worth considering, but my attention has been elsewhere, so I haven't reviewed this in depth. If someone else could review it, that would be great.

stephengold avatar Jul 26 '22 20:07 stephengold

I am in doubt if we should add this to the engine or not. And if it will be confusing to have two identical implementations one keeps the Armature instance (AvatarMask) and one does not (ArmatureMask).

I prefer core members decide about this and if they are positive about this addition then I can continue reviewing the code.

Ali-RS avatar Dec 31 '22 20:12 Ali-RS

I agree with you Ali, two identical implementations in core package, would just mess up. The AnimationMask interface gives programmers the freedom to write their own functionality and that's perfectly fine. If there is nothing else to discuss, I plan to close this PR within 24 hours.

capdevon avatar Jan 02 '23 09:01 capdevon