capsule icon indicating copy to clipboard operation
capsule copied to clipboard

x86_64 capsulerun should panic on 32-bit target, or somehow get it to work

Open fasterthanlime opened this issue 6 years ago • 1 comments

CreateRemoteThread doesn't work for 64->32, but it does work for 32->64.

Re CI testing, this means we have to split build/test/strip into different phases so that we can:

  • Build both archs for windows
  • Run 32->32, 32->64 and 64->64 tests
  • Strip both

..which is annoying, especially since linux 32 & 64 are built in different pipelines, but moving tests a separate pipeline (that could use artifacts from previous pipelines) seems slow? Might be the right thing to do still, idk.

fasterthanlime avatar Apr 16 '19 12:04 fasterthanlime

Ok, here's the non-insane way to do it: ship an inject-helper program and use it if the architectures don't match:

https://github.com/obsproject/obs-studio/blob/93cc09f07811a189e7258af9f1035f30d0e885fc/plugins/win-capture/game-capture.c#L896-L934

fasterthanlime avatar Apr 16 '19 12:04 fasterthanlime