ztunnel icon indicating copy to clipboard operation
ztunnel copied to clipboard

Published 20 hours ago • verified publisher icon istio

Initial connection MDS implementation

Open howardjohn opened this issue 1 year ago • 4 comments

  • Store each connection in a shared map
  • Capture special IP address, redirect to MDS handler
  • MDS handler takes 4 tuple as input.
  • Response is JSON containing identity

Also has an example Golang library implementation to add HTTP middleware that extracts the identity.

Istio tests: https://github.com/istio/istio/pull/44536 (blocked by this PR, of course), which also show how to use it

Original PR in https://github.com/istio/ztunnel/pull/504 got force deleted so cannot re-open

howardjohn avatar Feb 07 '24 19:02 howardjohn

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Mar 15 '24 22:03 istio-testing

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
test_ztunnel c8c232c03b3dc92082dbc24562c5d9f2e641d84b link unknown /test test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

istio-testing avatar May 15 '24 20:05 istio-testing

Do we still want to merge this anytime soon? Sorry I missed it.

stevenctl avatar May 15 '24 21:05 stevenctl

IMO it's worth doing. also, I did not realize that my review would get retroactively upgraded... 😬

ilrudie avatar May 15 '24 21:05 ilrudie