release-builder icon indicating copy to clipboard operation
release-builder copied to clipboard

Add multi platforms support for RepoOutDir

Open TrevorTaoARM opened this issue 3 years ago • 4 comments

Add multi-platform output dir support for arm64 and other platforms, which is used in archive, package(deb, rpm), docker build actions.

Signed-off-by: TrevorTaoARM [email protected]

TrevorTaoARM avatar Mar 23 '22 12:03 TrevorTaoARM

😊 Welcome @TrevorTaoARM! This is either your first contribution to the Istio release-builder repo, or it's been awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

istio-policy-bot avatar Mar 23 '22 12:03 istio-policy-bot

Hi @TrevorTaoARM. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Mar 23 '22 12:03 istio-testing

Actually this would mean that users on non-linux/amd64 can no longer build a proper release. For example, someone running on OSX now gets a osx build which is not what we want. The build platform != target platform IMO

howardjohn avatar Mar 23 '22 15:03 howardjohn

Doing some testing with MacOS as John mentioned, but running into another issue that I need to fix first :(.

ericvn avatar Mar 23 '22 19:03 ericvn