pkg

pkg copied to clipboard

This adds the concept of feature support for our various environment variables, and sets all variables to unknown for now. Users can call SetVarStatus to update the support level of a given env var.

😊 Welcome @therealmitchconnors! This is either your first contribution to the Istio pkg repo, or it's been awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

What format does the ctrlz page take? Hopefully the same one we will use for the checked-in canonicalization.

What format does the ctrlz page take? Hopefully the same one we will use for the checked-in canonicalization.

You can see the format here: https://drive.google.com/file/d/1EU9f711kP4TR6ixttN7GFohVcw48AGwR/view?usp=sharing

In the UI it says the 'Set of environment variables defined for the process" which implies we're dumping everything. Does it make sense to be more selective? Options include

• Only show the environment variables that are 'read'
• Sort the display to show non-UNKNOWN variables first

WDYT?

The env vars are already sorted to show known env vars first. I am happy to move the env vars which are not known to the ctrlz system (and therefore have no default) into a separate table if that helps.

@therealmitchconnors: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

What do we want the ctrlz page to show by default?

• All possible env vars
• All 'set' env vars
• All 'set' env vars with a non-default value

I suspect the latter would be the most useful. Variety of presentations possible to achieve delineation (sorting, split tables etc.)

On Sat, Jan 9, 2021 at 10:37 PM Istio Automation [email protected] wrote:

@therealmitchconnors https://github.com/therealmitchconnors: PR needs rebase.

Instructions for interacting with me using PR comments are available here https://git.k8s.io/community/contributors/guide/pull-requests.md. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue: repository.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/istio/pkg/pull/266#issuecomment-757426046, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACFAUPHDD234YJ74Z4Q3XQDSZFDI5ANCNFSM4TKSEQ2A .