operator icon indicating copy to clipboard operation
operator copied to clipboard

Published 20 hours ago • verified publisher icon istio

fix ICP list unmarshal issue.

Open morvencao opened this issue 5 years ago • 4 comments

Add proto tag for standard list meta, to align with k8s API, eg: https://github.com/kubernetes/api/blob/master/core/v1/types.go#L3538-L3542

morvencao avatar Dec 31 '19 07:12 morvencao

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

istio-policy-bot avatar Dec 31 '19 07:12 istio-policy-bot

Can you link an issue or describe what is fixed or add a test?

howardjohn avatar Dec 31 '19 18:12 howardjohn

@morvencao which issue will this pr fix?

elfinhe avatar Jan 02 '20 18:01 elfinhe

@morvencao: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Feb 12 '20 17:02 istio-testing