operator icon indicating copy to clipboard operation
operator copied to clipboard

Published 20 hours ago • verified publisher icon istio

add service to k8s spec

Open richardwxn opened this issue 5 years ago • 4 comments

the service part was added to k8s proto under ISCP spec before. however it is not added to tranlationConfig so it is not doing anything if we add the settings under component.k8s.service

richardwxn avatar Dec 20 '19 02:12 richardwxn

need to wait for the change in api repo: https://github.com/istio/api/pull/1229

richardwxn avatar Jan 09 '20 04:01 richardwxn

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test_operator c829065c58e6bf5cb5b29a08f031c5f0fdaba299 link /test test_operator
e2e_operator c829065c58e6bf5cb5b29a08f031c5f0fdaba299 link /test e2e_operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

istio-testing avatar Jan 12 '20 04:01 istio-testing

@richardwxn please move this pr to istio/istio.

ostromart avatar Jan 14 '20 22:01 ostromart

@richardwxn: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Feb 12 '20 17:02 istio-testing