istio.io icon indicating copy to clipboard operation
istio.io copied to clipboard

fix slider items on mobile

Open Arhell opened this issue 1 year ago • 2 comments

resolve https://github.com/istio/istio.io/issues/15334

Arhell avatar Jun 26 '24 06:06 Arhell

That's awesome, Ihor. I really appreciate that you help out with things like this! The spacing between the items is probably a little wide when. you're at the smallest setting

Screenshot 2024-06-26 at 9 40 42 PM

anything we can do about that?

craigbox avatar Jun 26 '24 09:06 craigbox

@craigbox enlarged the image, should be better

Arhell avatar Jun 27 '24 21:06 Arhell

I can still break this with certain sized but merging in the name of iterative improvement

/cherry-pick release-1.22

craigbox avatar Jul 02 '24 23:07 craigbox

@craigbox: once the present PR merges, I will cherry-pick it on top of release-1.22 in a new PR and assign it to you.

In response to this:

I can still break this with certain sized but merging in the name of iterative improvement

/cherry-pick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

istio-testing avatar Jul 02 '24 23:07 istio-testing

@craigbox: new pull request created: #15377

In response to this:

I can still break this with certain sized but merging in the name of iterative improvement

/cherry-pick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

istio-testing avatar Jul 02 '24 23:07 istio-testing