istio.io
istio.io copied to clipboard
Include sidecar.env for VM configuration
Please provide a description for what this PR is for.
BUG: https://github.com/istio/istio/issues/34058 PR: https://github.com/istio/istio/pull/35048 If the revision is set, we try to use the same discovery address that we setup in /etc/hosts. It involves using sidecar.env to pass a revisioned istiod address.
And to help us figure out who should review this PR, please put an X in all the areas that this PR affects.
- [ ] Configuration Infrastructure
- [X] Docs
- [X] Installation
- [X] Networking
- [ ] Performance and Scalability
- [ ] Policies and Telemetry
- [ ] Security
- [ ] Test and Release
- [ ] User Experience
- [ ] Developer Infrastructure
If sidecar.env is being merged into cluster.env, can this PR be closed?
@xulingqing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| doc.test.profile_default_istio.io | aab8296317d2d4d5b60cb0aeef0de359aaa634a4 | link | true | /test doc.test.profile_default |
| doc.test.profile-default_istio.io | aab8296317d2d4d5b60cb0aeef0de359aaa634a4 | link | true | /test doc.test.profile-default |
| doc.test.profile-demo_istio.io | aab8296317d2d4d5b60cb0aeef0de359aaa634a4 | link | true | /test doc.test.profile-demo |
| doc.test.profile-minimal_istio.io | aab8296317d2d4d5b60cb0aeef0de359aaa634a4 | link | true | /test doc.test.profile-minimal |
| doc.test.profile-none_istio.io | aab8296317d2d4d5b60cb0aeef0de359aaa634a4 | link | true | /test doc.test.profile-none |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.