client-go icon indicating copy to clipboard operation
client-go copied to clipboard

Patch 1

Open mshri10 opened this issue 5 years ago • 5 comments

mshri10 avatar Jun 12 '20 12:06 mshri10

😊 Welcome @mshri10! This is either your first contribution to the Istio client-go repo, or it's been awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

istio-policy-bot avatar Jun 12 '20 12:06 istio-policy-bot

@mshri10: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Jun 12 '20 12:06 istio-testing

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Jun 12 '20 12:06 googlebot

Hi @mshri10. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Jun 12 '20 12:06 istio-testing

@mshri10 Thanks for contributing! What is the purpose of this PR?

jasonwzm avatar Jun 12 '20 17:06 jasonwzm

Closing as this is nearly 3 years old

jacob-delgado avatar Apr 14 '23 19:04 jacob-delgado