api

api copied to clipboard

according to: https://github.com/istio/istio/issues/23470#issuecomment-630302121 fix #1783

Hi @ktalg. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

A make gen is needed.

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

/retest

@ktalg: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests: Test name Commit Details Required Rerun command release-notes_api d5a2a3d link false /test release-notes_api

@ericvn It seems that a release-notes-none is needed.

Related to https://github.com/istio/api/pull/2216

/test release-notes_api

Looking through the referenced PRs and some other PRs, I'm not sure this is accurate. @howardjohn probably has the most knowledge of the gateway/sidecar settings noted here.