api icon indicating copy to clipboard operation
api copied to clipboard

Move WorkloadGroup/WorkloadEntry to core API group

Open williamaronli opened this issue 5 years ago • 3 comments

draft change for the ref https://github.com/istio/istio/issues/27682

williamaronli avatar Oct 07 '20 03:10 williamaronli

@williamaronli: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
gencheck_api 2dd39b31f2c740895ea2363cb9e472306cee3760 link /test gencheck_api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

istio-testing avatar Oct 07 '20 03:10 istio-testing

John, please see my response to your comments on the same issue. We want to have API group accurately reflect the purpose of the CRD resources, so that customers will not be confused when they create ACL for different admins.

liminw avatar Oct 07 '20 16:10 liminw

@liminw @justinwei2 @smawson @liminw could we come to a consensus? whether currently the workloadgroup and workloadentry which is designed for the VM should be moved under a new folder core

williamaronli avatar Oct 07 '20 17:10 williamaronli

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2020-10-07. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

istio-policy-bot avatar May 15 '24 23:05 istio-policy-bot