api icon indicating copy to clipboard operation
api copied to clipboard

Document new sidecar.istio.io/holdApplicationUntilProxyStarts annotation

Open rolandkool opened this issue 5 years ago • 4 comments

Documents https://github.com/istio/istio/issues/27508

rolandkool avatar Sep 24 '20 16:09 rolandkool

😊 Welcome @rolandkool! This is either your first contribution to the Istio api repo, or it's been awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

istio-policy-bot avatar Sep 24 '20 16:09 istio-policy-bot

Hi @rolandkool. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Sep 24 '20 16:09 istio-testing

@rolandkool thanks for the PR, this was discussed in networking WG, and the consensus is to configure this holdApplicationUntilProxyStarts via ProxyConfig which Istio already allows user to enable annotation per deployment for any config within ProxyConfig today.

linsun avatar Oct 01 '20 15:10 linsun

@rolandkool: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Jan 14 '21 14:01 istio-testing