appstore-connect-sdk icon indicating copy to clipboard operation
appstore-connect-sdk copied to clipboard

Stay update with App Store Connect API latest version

Open dongsuo opened this issue 1 year ago • 3 comments

Since App Store Connect API released 3.1 version now, will this repo upgrade to keep in pace with Connect API's version?

dongsuo avatar Nov 04 '23 09:11 dongsuo

No updates planned at this time.

This project uses openapi-generator-cli to generate TypeScript code, but I found that it cannot generate code very well. There are many type errors and need to be modified manually again. Once the openapi spec json changes, it will be difficult to maintain.

I was wondering if there is a better way to maintain the repository. Like not using OpenAPI Generator, but there isn't a good answer yet.

isaced avatar Nov 08 '23 02:11 isaced

Regarding the mentioned TypeScript type error problem, an example:

app_store_connect_api_2.2_openapi.json

...
      "SubscriptionStatusUrlVersion" : {
        "type" : "string",
        "enum" : [ "V1", "V2", "v1", "v2" ]
      },
...

Generated code:

export const SubscriptionStatusUrlVersion = {
    V1: 'V1',
    V2: 'V2',
    V1: 'v1',
    V2: 'v2'
} as const;

error: An object literal cannot have multiple properties with the same name.ts(1117)

There are many more like this, probably dozens of files with problems.

isaced avatar Nov 08 '23 02:11 isaced