parquetjs icon indicating copy to clipboard operation
parquetjs copied to clipboard

thrift module is dependent on ws module

Open kessler opened this issue 8 years ago • 3 comments

the thrift module source is hosting on fsf git not on github, I'm not familiar with the procedure for submitting PRs and such but we might need to fork it to a non ws dependent version

kessler avatar Sep 07 '17 11:09 kessler

forking it would not be a problem because we just use the thrift module for parsing not networking, we just don't use that code.

dominictarr avatar Sep 08 '17 15:09 dominictarr

That's an excellent idea.

On Fri, Sep 8, 2017 at 6:10 PM, Dominic Tarr [email protected] wrote:

forking it would not be a problem because we just use the thrift module for parsing not networking, we just don't use that code.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ironSource/parquetjs/issues/1#issuecomment-328130166, or mute the thread https://github.com/notifications/unsubscribe-auth/AAI_p6cdRJUk9m35yrfqt1uYM2DqwndMks5sgVjhgaJpZM4PPqFu .

kessler avatar Sep 11 '17 13:09 kessler

native deps (all optional/non-essential)

  • ws
  • brotli
  • snappy
  • lzo

asmuth avatar Nov 14 '17 15:11 asmuth