traitlets

traitlets copied to clipboard

👋 colleagues! i just wondered when you may push a 5.x release to pip and conda forge. Right now with python 3.8 traitlets is throwing some warnings that are causing some issues with our builds (see below). i see that pip and conda forge as using 4.x. i see 3 release bundles here for 5.x! AND int hat bundle see a fix here in the repo.

Executing: 100% 34/34 [00:06<00:00,  4.86cell/s]
/opt/conda/lib/python3.8/site-packages/traitlets/config/loader.py:795: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if len(key) is 1:

thank you for any help or info! Leah

Hi Leah,

There is a release Candidate of traitlets 5.0.0 on PyPI, you can install it with pip with the --pre flag:

pip install traitlets --pre --upgrade

Those syntax warnings should have been fixed. we don't push beta/rc on conda-forge though, I'm not even sure how to do RC on conda.

If the repo you have issues is public I'm happy to send a PR.

I was planning on making a final 5.0 release this friday is all is well.

oh hey there @Carreau !! thank you for the quick response. You know -- if you plan to make a release soon that is perfect.

this is our container -- and the PR i made to attempt to update traitlets (without realizing it wasn't yet conda or pip installable - my mistake!!)

https://github.com/earthlab/r-python-eds-lessons-env/pull/33/files

i'll simply force a rebuild next week after the 5.0 release. Thank you so much. i'll watch this repo for the release!

I can ping you once the release is done on PyPI and conda-forge. I'll likely release tomorrow. Let me know if you need a 4.3.4 with the syntax warnings fixed, I can also do this.

Traitlets 5.0 should be out on PyPI will take a few hours to be on conda forge.

thank you so much @Carreau !! got it! will test later today once it propagates through conda-forge.

Sorry it took a bit longer, it was just published a few minutes ago.

Closing this issue feel free to still comment or ping me if there is anything that needs fixing.

@Carreau Would you mind cutting an additional 4.3.4 release including the #551 SyntaxWarning fix?

We're pinned to 4.3.x and would much appreciate the resolved warning.

I'll try. I haven't looked at 4.3.x and will have too look at what went into it. unless @rmorshea want to do one before I look into it.

Thank you, I appreciate the extra effort.

I briefly reviewed the 4.3.3...4.3.x, the PRs merged are:

#538 * Class constructor signature updates. #550 * SyntaxWarning #551 * SyntaxWarning #552 * CI version update #555 * Callable Traitlet #560 (#545 backport) * Doc Updates

If it'd be useful I'd be happy to help write the changelog.

a 4.3 release would be useful for us too if it's not too much effort.. i believe some of the packages in our envt also have 4.3 pinned. I haven't begun to dig into which ones yet but planned to. cheers all!