ipfs-webui

ipfs-webui copied to clipboard

Describe the bug While interacting with other elements on page, the PDF viewer re-renders.

To Reproduce Steps to reproduce the behavior:

1. Import a sample PDF in either webui/desktop
2. Try interacting with ui elements around the pdf
3. PDF viewer re-renders.
4. ReRenders can be expensive and based on the size of file it can take longer.

Expected behavior It should not re-render.

Screenshots

https://github.com/ipfs/ipfs-webui/assets/1895906/e573131f-c233-48d7-9f52-0558101a2f95

Desktop (please complete the following information):

• OS: MacOS Ventura 13.5 (22G74)
• Browser Chrome, IPFS - Desktop
• Version Version 115.0.5790.114 (Official Build) (arm64), webui: https://github.com/ipfs/ipfs-webui/commit/a43dd23

Additional context It looks like it should be fairly straightforward to remove pdf-view updates from the rendering cycle.

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review. In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment. Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

• "Priority" labels will show how urgent this is for the team.
• "Status" labels will show if this is ready to be worked on, blocked, or in progress.
• "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.