ipfs-webui

ipfs-webui copied to clipboard

https://github.com/ipfs/ipfs-webui/releases/tag/v2.17.3 states CID bafybeihfkeactw26tghz7m3puzh4zqlukvft2f7atfdc7t2qmqn2vszhc4 and that CID shows previous release version:

Potential fix is to run build again, AFTER version bump but BEFORE changelog and CAR are generated (and recreate CAR so it shows the new version):

• https://semantic-release.gitbook.io/semantic-release/support/faq#how-can-i-use-a-npm-build-script-that-requires-the-package.jsons-version

Or to solve chicken vs egg problem, we could remove the tag from UI, and only have revision. This way it will be okay to have revision 1 commit before the tag.

@SgtPooki I'm marking this as P0 because we can't ship a release with invalid version in UI.

#2000 removes the Web UI version for now. I think it's a good temporary solution. However, I think that after @SgtPooki comes back, we should at least make sure it says the correct revision. I agree that removing the Web UI version is fine overall since many people confuse it with Desktop / Kubo version.

https://github.com/ipfs/ipfs-webui/pull/2000 got merged, if we are ok with only having the revision (seems like improved UX for ipfs-desktop users) this can be closed.

@SgtPooki your call.

Yea I'm good with only having the revision on there. The only issue I see is that it could cause issues when users try to communicate bugs for specific versions, and when maintaining issues because we don't think about revisions as quickly as we do version numbers. So we will need to decode that revision every time. I'll leave this open and leave it as P2

Going to close this and we can address this if it comes up again