ipfs-webui icon indicating copy to clipboard operation
ipfs-webui copied to clipboard

Switch publish-release-build.yml to CAR

Open aptalca opened this issue 4 years ago • 3 comments

Describe the bug Just a heads up (in case you haven't noticed already), the GitHub actions for the ci have been failing for the last few commits (js test) and the release binary upload action also failed in this repo.

aptalca avatar Sep 06 '21 14:09 aptalca

Thanks for raising this.

Fixing E2E tests against js-ipfs is already tracked in https://github.com/ipfs/ipfs-webui/issues/1737

The job that attaches binaries failed due to unrelated reasons.

I believe we should rewrite it to read the latest release via github api (either dedicated action or https://api.github.com/repos/ipfs/ipfs-webui/releases/latest) and then generate TAR and CAR by fetching the CID listed in Release notes.

I won't have bandwidth to do this any time soon, but PR welcome.

lidel avatar Sep 10 '21 13:09 lidel

Looks like the tar file was created successfully, but the upload failed. Can you rerun that action from the github gui?

aptalca avatar Sep 19 '21 19:09 aptalca

  • The TAR failed to upload today again – lacks a robust retry
  • Ideally, we would remove TAR and only use verifiable CAR
  • For now, attached both manually to v2.14.0 (but we may gzip CAR when we automate this)

lidel avatar Feb 02 '22 20:02 lidel

I believe this should be resolved now as all our releases contain a CAR file

SgtPooki avatar Nov 29 '22 20:11 SgtPooki