boxo icon indicating copy to clipboard operation
boxo copied to clipboard

Remove provider query manager

Open Jorropo opened this issue 1 year ago • 2 comments

Based on #535

Jorropo avatar Jan 03 '24 18:01 Jorropo

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (remove-content-routing-from-bitswap-network@2dbd42a). Click here to learn what that means.

:exclamation: Current head f3d731b differs from pull request most recent head 2e813d8. Consider uploading reports for the commit 2e813d8 to get more accurate results

Impacted file tree graph

@@                              Coverage Diff                               @@
##             remove-content-routing-from-bitswap-network     #536   +/-   ##
==============================================================================
  Coverage                                               ?   65.31%           
==============================================================================
  Files                                                  ?      206           
  Lines                                                  ?    25244           
  Branches                                               ?        0           
==============================================================================
  Hits                                                   ?    16488           
  Misses                                                 ?     7281           
  Partials                                               ?     1475           
Files Coverage Δ
bitswap/bitswap.go 69.51% <ø> (ø)
bitswap/client/client.go 86.86% <100.00%> (ø)
...tswap/client/internal/messagequeue/messagequeue.go 84.92% <ø> (ø)
bitswap/network/ipfs_impl.go 78.86% <100.00%> (ø)
bitswap/options.go 44.44% <100.00%> (ø)
bitswap/server/server.go 59.75% <100.00%> (ø)
bitswap/testnet/peernet.go 38.46% <100.00%> (ø)
blockservice/test/mock.go 100.00% <100.00%> (ø)
examples/unixfs-file-cid/main.go 41.21% <100.00%> (ø)
gateway/blocks_backend.go 42.23% <ø> (ø)
... and 4 more

codecov[bot] avatar Jan 03 '24 18:01 codecov[bot]

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Jorropo avatar Jan 11 '24 18:01 Jorropo

ProviderQueryManager has been moved and refactored sufficiently where we do not need this PR, and if we want to make changes like this in the future it should be done in a new PR.

gammazero avatar Nov 26 '24 19:11 gammazero