boxo icon indicating copy to clipboard operation
boxo copied to clipboard

Move providing responsabilities from bitswap to blockservice

Open Jorropo opened this issue 1 year ago • 3 comments

Jorropo avatar Jan 03 '24 17:01 Jorropo

Codecov Report

Attention: Patch coverage is 49.15254% with 30 lines in your changes missing coverage. Please review.

Project coverage is 65.45%. Comparing base (79cb4e2) to head (4060154). Report is 8 commits behind head on revert-bad-sessions-changes.

Files with missing lines Patch % Lines
blockservice/blockservice.go 55.00% 13 Missing and 5 partials :warning:
blockservice/providing_blockstore.go 14.28% 11 Missing and 1 partial :warning:

Impacted file tree graph

@@                       Coverage Diff                       @@
##           revert-bad-sessions-changes     #534      +/-   ##
===============================================================
- Coverage                        65.56%   65.45%   -0.12%     
===============================================================
  Files                              207      208       +1     
  Lines                            25597    25511      -86     
===============================================================
- Hits                             16782    16697      -85     
+ Misses                            7336     7332       -4     
- Partials                          1479     1482       +3     
Files with missing lines Coverage Δ
bitswap/bitswap.go 69.51% <ø> (+2.07%) :arrow_up:
bitswap/options.go 41.17% <ø> (-3.27%) :arrow_down:
bitswap/server/server.go 58.50% <100.00%> (-7.97%) :arrow_down:
gateway/blocks_backend.go 42.23% <ø> (+0.13%) :arrow_up:
blockservice/providing_blockstore.go 14.28% <14.28%> (ø)
blockservice/blockservice.go 74.41% <55.00%> (-3.82%) :arrow_down:

... and 11 files with indirect coverage changes

codecov[bot] avatar Jan 03 '24 17:01 codecov[bot]

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

  • #536 Graphite
  • #535 Graphite
  • #534 Graphite 👈
  • #578 Graphite
  • main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Jorropo and the rest of your teammates on Graphite Graphite

Jorropo avatar Jan 11 '24 18:01 Jorropo

Replaced by #677

gammazero avatar Sep 30 '24 23:09 gammazero