ionic-stencil-hn-app icon indicating copy to clipboard operation
ionic-stencil-hn-app copied to clipboard

Published 20 hours ago • verified publisher icon ionic-team

refactor(): extracted stencil-router in app-routes component

Open ionutVizitiu opened this issue 8 years ago • 5 comments

I think it will be much cleaner to have all routes in one place and extend that component even more in the future by having more routes per module. You can see the app here: https://ionic-hn.firebaseapp.com

ionutVizitiu avatar Sep 26 '17 19:09 ionutVizitiu

hi @jgw96, @adamdbradley. I am very interested in your feedback for this PR.

ionutVizitiu avatar Oct 03 '17 19:10 ionutVizitiu

Hey @ionutVizitiu this looks great! Ill review this asap.

jgw96 avatar Oct 09 '17 17:10 jgw96

@jgw96 not sure we want to do this. Obviously it does not break anything but it will add overhead (extremely small amount). I think that for best practices it might make sense, but this application is all about speed so we might want to keep it as simple as possible.

jthoms1 avatar Oct 10 '17 13:10 jthoms1

why is it cleaner to have all routes in one place ? if i using modules i want the routes in the module and not in other folders

DrMabuse23 avatar Oct 23 '17 11:10 DrMabuse23

@DrMabuse23 , exactly. This is what I was saying by "extend that component even more in the future by having more routes per module"

ionutVizitiu avatar Oct 23 '17 18:10 ionutVizitiu