radio4000 icon indicating copy to clipboard operation
radio4000 copied to clipboard

Published 20 hours ago • verified publisher icon internet4000

Keyboard shortcuts conflict in text inputs

Open oskarrough opened this issue 6 years ago • 3 comments
trafficstars

It's not yet working as it should. player keyboard shortcuts are triggering inside (some) inputs.

https://github.com/internet4000/radio4000/pull/282#issuecomment-444273366 https://github.com/internet4000/radio4000/issues/269

oskarrough avatar Dec 05 '18 10:12 oskarrough

Fixed in #285

oskarrough avatar Dec 06 '18 16:12 oskarrough

This is still a problem in https://github.com/internet4000/radio4000/pull/298

oskarrough avatar Jan 10 '19 17:01 oskarrough

It happens when we use the normal <input>. When we use Ember's {{input}}, the keyboard events don't trigger more than they should.

So… to close this issue we have to make sure that the shortcuts defined in https://github.com/internet4000/radio4000/blob/master/app/mixins/keyboard-shortcuts-global.js DO NOT trigger inside either <input> or {{input}}.

oskarrough avatar Jan 14 '19 10:01 oskarrough