interactions.py icon indicating copy to clipboard operation
interactions.py copied to clipboard

[BUG] AuditLogEventType 130, 131, 132 missing

Open LightD31 opened this issue 1 year ago • 8 comments

Library Version

5.11.0

Describe the Bug

Class AuditLogEventType received an invalid and unexpected value 130, a new enum item will be created to represent this value. Please update interactions.py or report this issue on GitHub - https://github.com/interactions-py/interactions.py/issues

Steps to Reproduce

130 = Add a sound to the soundboard 131 = Modify a sound in the soundboard 132 = Delete a sound from the soundboard

Expected Results

AuditLogeventType should recognize these

Minimal Reproducible Code

No response

Traceback

No response

Checklist

  • [X] I have searched the open issues for duplicates.
  • [X] I have shown the entire traceback, if possible.
  • [X] I have removed my token from display, if visible.
  • [X] I have attempted to debug this myself, and I believe this issue is with the library

Additional Information

No response

LightD31 avatar Jan 27 '24 22:01 LightD31

I can look into that 🙋‍♂️

Bastien1533 avatar Jan 30 '24 23:01 Bastien1533

Seems like an undocumented part of the api, I can suggest names for the events to wait the official implémentation. None of the less it is an easy fix.

Bastien1533 avatar Jan 31 '24 12:01 Bastien1533

It's because it's undocumented that I made an issue report instead of a PR

LightD31 avatar Jan 31 '24 13:01 LightD31

Okay I see, maybe we could use like SOUNDBOARD_CREATE,SOUNDBOARD_EDIT and SOUNDBOARD_DELETE in the meantime.

Bastien1533 avatar Jan 31 '24 13:01 Bastien1533

If it's undocumented, the usual thing to do is to simply not add anything until it is. We've ran into issues in the past where we named something too early and would have to do a breaking change to rename it.

AstreaTSS avatar Jan 31 '24 13:01 AstreaTSS

Okay, then we hold that issue for now.

Bastien1533 avatar Jan 31 '24 14:01 Bastien1533

Setting this issue to pending until documentation exists for the new enumerations.

eightween avatar Feb 03 '24 03:02 eightween