interactions.py
interactions.py copied to clipboard
interactions-py
fix(autocomplete dispatch): ID -> name
This allows multi-guild usage when 2 or more scopes are used on a command since the command will have a different ID but the same name in different guilds. Reported here
About
This pull request is about (X), which does (Y).
Checklist
- [x] I've ran
pre-committo format and lint the change(s) made. - [x] I've checked to make sure the change(s) work on
3.8.6and higher. - [ ] This fixes/solves an Issue (If existent):.
- resolves #
- I've made this pull request for/as: (check all that apply)
- [ ] Documentation
- [ ] Breaking change
- [ ] New feature/enhancement
- [x] Bugfix
In this case if i trigger autocomplete in first guild both funtions with different command ids will be called
In this case if i trigger autocomplete in first guild both funtions with different command ids will be called
You want to have different responses for different guilds with the same command?
You want to have different responses for different guilds with the same command?
Yes! /s I think it should call only command with equal command id
You want to have different responses for different guilds with the same command?
Yes! /s I think it should call only command with equal command id
Is there a real need for that?
Is there a real need for that? Honestly idk. Just found this.
I think we should just keep it as it is rn
It does make sense that the command with equivalent ID invokes only the autocomplete for it since the ID was given I can imagine some sort of tag system or something where the command names are the same but autocomplete differently in different guilds Would it be difficult to implement it? If it is, then I think it's fine
It does make sense that the command with equivalent ID invokes only the autocomplete for it since the ID was given I can imagine some sort of tag system or something where the command names are the same but autocomplete differently in different guilds Would it be difficult to implement it? If it is, then I think it's fine
Yeah it's kinda hard to do it/it requires effort which is not really nessecary, especially considering the fact that you can just check ctx.guild_id inside autocomplete i think?