interactions.py icon indicating copy to clipboard operation
interactions.py copied to clipboard

Published 20 hours ago • verified publisher icon interactions-py

refactor: split dispatch in two methods

Open Damego opened this issue 3 years ago • 9 comments

About

This pull request splits _dispatch_event in two other methods.

Checklist

  • [ ] I've ran pre-commit to format and lint the change(s) made.
  • [x] I've checked to make sure the change(s) work on 3.8.6 and higher.
  • [ ] This fixes/solves an Issue (If existent):.
    • resolves #
  • I've made this pull request for/as: (check all that apply)
    • [ ] Documentation
    • [ ] Breaking change
    • [ ] New feature/enhancement
    • [ ] Bugfix

Damego avatar Aug 07 '22 15:08 Damego

Can I include #1004 into this pr?

Damego avatar Aug 07 '22 15:08 Damego

Resolved merge conflict lol. Why it shows changes which already in unstable?

Damego avatar Aug 10 '22 04:08 Damego

oh damn... rebase in third time

Damego avatar Aug 20 '22 08:08 Damego

oh damn... rebase in third time

Wait until #1022

EepyElvyra avatar Aug 20 '22 08:08 EepyElvyra

okay

Damego avatar Aug 20 '22 08:08 Damego

Will mark as draft

Damego avatar Aug 20 '22 08:08 Damego

I hate this pr

Damego avatar Sep 04 '22 07:09 Damego

I hate this pr

Perfect

EepyElvyra avatar Sep 04 '22 07:09 EepyElvyra

Its fine now

Damego avatar Sep 04 '22 08:09 Damego

I will reopen this fucking pr

Damego avatar Oct 05 '22 06:10 Damego

fine

Damego avatar Oct 05 '22 08:10 Damego

Can you resolve conflicts and re-test?

Catalyst4222 avatar Oct 29 '22 17:10 Catalyst4222

Can you resolve conflicts and re-test?

Resolved and it works

Damego avatar Oct 30 '22 07:10 Damego

image Merge it pls. Every new rebase takes more time than previous

Damego avatar Nov 03 '22 08:11 Damego

image Merge it pls. Every new rebase takes more time than previous

I find it satisfying for how long this PR is already opened without being merged and how it just gets worse and worse xD

EepyElvyra avatar Nov 22 '22 20:11 EepyElvyra

This pr does not changes code or logic of dispatching. Im just moved code in function. I know its impossible to review this pr and better just look at my branch

Damego avatar Nov 23 '22 01:11 Damego

image Merge it pls. Every new rebase takes more time than previous

I find it satisfying for how long this PR is already opened without being merged and how it just gets worse and worse xD

This pr contain absolutely same code we have on unstable branch soooo do you mean our code gets worse and worse then lol?

Damego avatar Nov 23 '22 01:11 Damego

image Merge it pls. Every new rebase takes more time than previous

I find it satisfying for how long this PR is already opened without being merged and how it just gets worse and worse xD

This pr contain absolutely same code we have on unstable branch soooo do you mean our code gets worse and worse then lol?

Fine but has it been tested enough to ensure that you did everything correctly? So we know that you did not indent something wrong etc

EepyElvyra avatar Nov 23 '22 07:11 EepyElvyra

I tested it right now and yes, it works fineee (as expected). _dispatch_event properly calls methods to dispatch interactions and discord events.

Damego avatar Nov 23 '22 08:11 Damego

Review it here https://github.com/Damego/library/blob/ref-split-dispatch/interactions/api/gateway/client.py#L362

Damego avatar Nov 23 '22 08:11 Damego

looks like it needs another rebase (sorry)

EepyElvyra avatar Nov 23 '22 19:11 EepyElvyra