haskell.nix icon indicating copy to clipboard operation
haskell.nix copied to clipboard

Published 20 hours ago • verified publisher icon input-output-hk

Fix hls build for ghc 9.2

Open hamishmack opened this issue 3 years ago • 8 comments

This adds flags: -haddockcomments to the default cabal.project of haskell-language-server to fix building on ghc 9.2

hamishmack avatar Aug 15 '22 06:08 hamishmack

Is this an upstream issue?

michaelpj avatar Aug 16 '22 07:08 michaelpj

I think it is covered by https://github.com/haskell/haskell-language-server/issues/2982

hamishmack avatar Aug 16 '22 09:08 hamishmack

I don't understand why HLS isn't broken in the same way, then.

michaelpj avatar Aug 16 '22 09:08 michaelpj

Since they just have the one cabal.project without this flag, now.

michaelpj avatar Aug 16 '22 09:08 michaelpj

It looks this guard against building with 9.2 https://github.com/haskell/haskell-language-server/blob/e55004a0cc9b727423a16cec4f5103a4df685eb6/plugins/hls-haddock-comments-plugin/hls-haddock-comments-plugin.cabal#L21-L24 is not in hackage https://hackage.haskell.org/package/hls-haddock-comments-plugin-1.0.1.0/hls-haddock-comments-plugin.cabal

hamishmack avatar Aug 16 '22 10:08 hamishmack

Ah, maybe that snuck in on master only.

michaelpj avatar Aug 16 '22 10:08 michaelpj

bors try

hamishmack avatar Aug 18 '22 02:08 hamishmack

try

Build failed:

iohk-bors[bot] avatar Aug 18 '22 03:08 iohk-bors[bot]

bors try

hamishmack avatar Aug 18 '22 05:08 hamishmack

try

Build succeeded:

iohk-bors[bot] avatar Aug 18 '22 06:08 iohk-bors[bot]