David Ko

If [allow-node-drain-with-the-last-healthy-replica](https://longhorn.io/docs/1.2.4/references/settings/#allow-node-drain-with-the-last-healthy-replica) is false by default, Longhorn will ensure at least one healthy volume replica available in another node before evicting all pods from the draining node. http://github.com/longhorn/longhorn-manager/blob/95b9b88e861f60ae7a39b396725530b953057e4c/controller/instance_manager_controller.go#L585-L619 cc @PhanLe1010

I will keep this as draft after discussing it with @c3y1huang , and revisit this after https://github.com/longhorn/longhorn/issues/4038.

> > > > I am not sure if there are other cases > > Will the backup CRs be taken over by other nodes in this case? If No,...

> > . IIRC, the transferring will only happen when the node is not ready or the manager pod on that node is unavailable. > > Yeah, I backup CR...

In general, LGTM. Have some feedback, please resolve others' comments as well before the merge. P.S. this needs longhorn/longhorn change as well because a new setting will be introduced.

@mantissahz Please backport this to 1.3.x and 1.2.x.

@PhanLe1010 do we still need this one?

https://github.com/innobead/huber/runs/1930794494?check_suite_focus=true There was a build issue happening in docker buildx and it should be fixed at upstream first. ``` #9 59.21 cargo fmt #9 63.71 cargo build --release --workspace --exclude=huber-generator...

Although the automatic build is not ready, the code is ready for ARMv7 supported.

Thanks for the contribution. It looks you want to solve several issues or enhancements, so I would suggest to seperate this PR first, so we can focus on each problem...