web-search-navigator icon indicating copy to clipboard operation
web-search-navigator copied to clipboard

Migrate to TypeScript

Open infokiller opened this issue 7 years ago • 1 comments

NOTE: feedback is welcome from everyone, but I especially want to get @mancze opinion on this as the main contributor to this project.

I'd like to propose to migrate the code of the extension to TypeScript and use its tooling (mainly via gts) to automatically lint and format the code (preferably enforced using commit hooks).

Pros:

  • Reducing the likelihood of bugs via static analysis done by the TypeScript compiler and linter
  • Better developer experience- TypeScript has better support for autocompletion, refactoring, etc.

Cons:

  • Less developers are familiar with the TypeScript language and tooling
  • Browsers generally don't support running TypeScript natively which forces the use of a compilation step

Overall I still believe this change to be worthwhile. @mancze what do you think?

infokiller avatar Sep 14 '18 13:09 infokiller

Sounds like a fun. I have nothing against TypeScript.

I must only note that it will mean a little more complicated process when shipping new version - Aside of the extension package itself I will have to provide also zipped sources of each version. It's the policy of the AMO portal. But it's no biggie.

mancze avatar Sep 26 '18 08:09 mancze