eightshift-libs icon indicating copy to clipboard operation
eightshift-libs copied to clipboard

Published 20 hours ago • verified publisher icon infinum

const defined after methods in Components class

Open dingo-d opened this issue 3 years ago • 0 comments

The following constant is located after methods in the Components class. Which is just not right.

https://github.com/infinum/eightshift-libs/blob/c80882b1be5266dd22f911efee4838e019573a72/src/Helpers/Components.php#L294-L318

We should follow the proposed WordPress conventions (which we were kinda doing unknowingly 😅) when ordering properties/methods in a class

  1. First the optional abstract or final keyword.
  2. Next a visibility keyword.
  3. Lastly, the optional static keyword.

dingo-d avatar Aug 24 '22 07:08 dingo-d