log15 icon indicating copy to clipboard operation
log15 copied to clipboard

v2.12 Build Issues

Open skriptble opened this issue 8 years ago • 3 comments

Hello, I noticed that a new tag for the v2 branch was created (v2.12), but it was tagged from the master branch not the v2 branch. This has brought in roughly 2 years worth of commits. Was this tag made accidentally?

skriptble avatar Oct 02 '17 16:10 skriptble

Same question here, I just noticed that the v2 branch (which we use through gopkg.in) got a breaking API change, causing build failures on the LXD codebase.

# github.com/lxc/lxd/shared/logging
shared/logging/log_posix.go:16: not enough arguments in call to log15.Must.SyslogHandler
	have (string, log15.Format)
	want (syslog.Priority, string, log15.Format)
shared/logging/log_posix.go:20: not enough arguments in call to log15.Must.SyslogHandler
	have (string, log15.Format)
	want (syslog.Priority, string, log15.Format)

stgraber avatar Oct 02 '17 18:10 stgraber

@inconshreveable any chance you can fix this?

stgraber avatar Nov 03 '17 04:11 stgraber

👍 +1

We had a breaking build due to the missing stack package:

package gopkg.in/inconshreveable/log15.v2/stack: cannot find package "gopkg.in/inconshreveable/log15.v2/stack" in any of:

kylechadha avatar Nov 07 '17 20:11 kylechadha