simplematrixbotlib icon indicating copy to clipboard operation
simplematrixbotlib copied to clipboard

feat: ✨ add ability to reply with text messages

Open HarHarLinks opened this issue 4 years ago • 5 comments

I did refactor send_markdown_message along the way because it is almost identical to send_text_message and code reply and other would be doubled up otherwise. This should improve maintainability while staying compatible with earlier versions.

Sending replies isn't so bad, but receiving and reading replies correctly is a harder problem. I think it is reasonable to just not go there and wait for MSC2781 https://github.com/matrix-org/matrix-doc/pull/2781 to arrive at which point the issue would be resolved.

I also revised the manual to reflect the changes.

Demo: image

HarHarLinks avatar Nov 27 '21 16:11 HarHarLinks

is there an chance that this could be merged ?

cutec-chris avatar Apr 08 '22 17:04 cutec-chris

We are waiting on MSC2781 https://github.com/matrix-org/matrix-spec-proposals/pull/2781

ghost avatar Apr 08 '22 19:04 ghost

We are waiting on MSC2781 matrix-org/matrix-spec-proposals#2781

@imbev: MSC3676 which starts fading out reply fallbacks has been merged and element has partially start dropping them as well (e.g. you can now reply with files etc. and you can send anything you want inside of threads).

HarHarLinks avatar Jul 30 '22 13:07 HarHarLinks

Relevant part of the spec - https://spec.matrix.org/v1.3/client-server-api/#forming-relationships-between-events

imbev avatar Jul 30 '22 17:07 imbev

The implementation in this branch does not match the current spec.

Current branch:

content["m.relates.to"] = {"m.in_reply_to": {"event_id": reply_to.event_id}}

Spec

{
  "m.relates_to": {
    "event_id": "$an_event",
    "rel_type": "org.example.relationship"
  }
}

imbev avatar Jul 30 '22 17:07 imbev