Ivan Levkivskyi

Results 392 comments of Ivan Levkivskyi

I think it should only return the actual type argument (i.e. `(int,)` in this case). Also IIUC it used to work in 3.8 by accident, please feel free to submit...

Yeah, this would be a reasonable thing to have. I will not have time to add it myself (and polish possible corner cases), but PRs are welcome.

Yeah, this is a known problem. I think one of the open PRs should address this.

Hm, this looks like a bug. I think for bare class objects `get_origin()` should always return the class object itself. Would you like to submit a PR?

> Yea, it would be great if then `get_origin` from this package would work on 3.6 the same as it does on 3.7 and 3.8. I was always think about...

I like the `is_forward_ref`. But for `eval_forward_ref` I think we should use more of typing logic used in `get_type_hints`, i.e. support custom `locals` and `globals`.

@allrod5 I think adding `is_forward_ref()` totally makes sense (it needs to also account the renaming of `_ForwardRef` to `ForwardRef` in newer Python versions). I recently needed it myself actually. Would...

I just uploaded new version to PyPI: https://pypi.org/project/typing-inspect/0.6.0/

Since 2.7 doesn't cause big troubles, I don't see this as urgent. But in general yes, I think it would make sense to drop Python 2 support by the end...