Should I remove the 2 following function too?

• def set_position_state(self, value)
• def set_current_position(self, value)

Codecov Report

Merging #165 into dev will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #165   +/-   ##
=======================================
  Coverage   58.14%   58.14%           
=======================================
  Files          16       16           
  Lines        1639     1639           
  Branches      165      165           
=======================================
  Hits          953      953           
  Misses        652      652           
  Partials       34       34

@lboue Will you be addressing the raised issues or should I take care of these after a merge maybe?

@ikalchev I don't like the idea of merging a PR that isn't finished yet, only to finish it later. Instead consider committing the changes directly to the PR branch. Maintainers do generally have the permission to do so.

OK. I will fix all that items ASAP.