cli icon indicating copy to clipboard operation
cli copied to clipboard

chore: rename go.mod and imports to v29

Open julienrbrt opened this issue 1 year ago • 4 comments

julienrbrt avatar Feb 05 '24 20:02 julienrbrt

Visit the preview URL for this PR (updated for commit 77fde95):

https://igntservices-docs--pr3945-julien-v29-b7vbijda.web.app

(expires Wed, 27 Mar 2024 09:32:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5

github-actions[bot] avatar Feb 05 '24 20:02 github-actions[bot]

brew and flatpack versions going to be updated in a different PR?

Those are just templates for snap and brew, ci does the push to the snapstore and homebrew repo at each tag. We probably should delete flatpak, as snap works well and flatpak was more hacky.

Also I noticed that the readme.md is using a Gitpod link with CLI v28.1.1 for "Open Ignite CLI in your web browser". Maybe we should update it.

100%, will do!

julienrbrt avatar Mar 08 '24 15:03 julienrbrt

Actually, I think we want people to open the latest release on gitpod, so linking unreleased v29 doesn't really make sense imho, as v29 is sort of nightly.

julienrbrt avatar Mar 08 '24 15:03 julienrbrt

we need to rename the consumer changes as well

Pantani avatar Mar 19 '24 21:03 Pantani

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 25.97%. Comparing base (b387b0f) to head (77fde95).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3945      +/-   ##
==========================================
- Coverage   25.98%   25.97%   -0.02%     
==========================================
  Files         304      304              
  Lines       25524    25528       +4     
==========================================
- Hits         6632     6630       -2     
- Misses      18316    18321       +5     
- Partials      576      577       +1     
Files Coverage Δ
ignite/cmd/account.go 0.00% <ø> (ø)
ignite/cmd/account_create.go 0.00% <ø> (ø)
ignite/cmd/account_delete.go 0.00% <ø> (ø)
ignite/cmd/account_export.go 0.00% <ø> (ø)
ignite/cmd/account_import.go 0.00% <ø> (ø)
ignite/cmd/account_list.go 0.00% <ø> (ø)
ignite/cmd/account_show.go 0.00% <ø> (ø)
ignite/cmd/chain.go 0.00% <ø> (ø)
ignite/cmd/chain_build.go 0.00% <ø> (ø)
ignite/cmd/chain_debug.go 0.00% <ø> (ø)
... and 177 more

... and 1 file with indirect coverage changes

codecov[bot] avatar Mar 20 '24 07:03 codecov[bot]