cli icon indicating copy to clipboard operation
cli copied to clipboard

Published 20 hours ago • verified publisher icon ignite

feat: add node command with bank query and send

Open gjermundgaraba opened this issue 3 years ago • 5 comments

Bounty address: cosmos1zra3wz596n0qc898myceka3q23x9rk8fuw65c7

Closes #2489

gjermundgaraba avatar May 30 '22 08:05 gjermundgaraba

@ilgooz Just to make sure, you're not waiting for me to do anything here right?

gjermundgaraba avatar Jun 14 '22 18:06 gjermundgaraba

Hey Gjermund!

I'm refactoring some bits, will push some commits soon!

ilgooz avatar Jun 14 '22 18:06 ilgooz

We should not require address prefix when querying, if the account address is used while querying

I don't think we are. I just tested it and it seems to work fine without the prefix. Updating the tests to show this now.

gjermundgaraba avatar Jun 14 '22 21:06 gjermundgaraba

@bjaanes oh okay, that comment was more like a comment to remind to myself during review, sorry for the confusion!

ilgooz avatar Jun 18 '22 08:06 ilgooz

I was making some fixes and improvements on this PR and also tweaking the integration package's API.

My changes are in this branch within https://github.com/ignite/cli/commit/a50618c65e55ae1eb0988860d9ac0f5bba32f3ee commit.

@jeronimoalbi @tbruyelle can you please take a look and maybe continue from here? So we can add those changes into this PR and finally merge it.

ilgooz avatar Jul 25 '22 13:07 ilgooz

Can we close this?

aljo242 avatar Aug 25 '22 19:08 aljo242