icalendar_light

icalendar_light copied to clipboard

Add iter_events_from_url for users to reader public ics url

Dec 08 '20 06:12 drinks5

Thank you. Please provide a test for that. Request mocking, if required, could be done with https://github.com/idlesign/pytest-responsemock

As a sidenote. It'd be also nice if upcoming CLI command could handle URLs (not only filepaths).

Dec 08 '20 07:12 idlesign

Thank you. Please provide a test for that. Request mocking, if required, could be done with https://github.com/idlesign/pytest-responsemock

As a sidenote. It'd be also nice if upcoming CLI command could handle URLs (not only filepaths).

Hello, I think what I should do is that test cases coverage the code I commited, am I right? and I want to mock the requests, write test cases to coverage the function iter_events_from_url, instead of iter_events or iter_events_upcoming

Dec 08 '20 08:12 drinks5

Hi.

Hello, I think what I should do is that test cases coverage the code I commited, am I right?

Yes just add one test for iter_events_from_url (to cover your code). You may either mock request or pick some real URL we can rely on in test.

Dec 08 '20 09:12 idlesign