moko-resources

moko-resources copied to clipboard

Hey,

with moko-resources prior to 0.24.0, moko resources were part of the application resources source path, thus you could add custom pathes to its source set. Now moko-resources has its own resources folder. Can you still add custom pathes? I have used it for generated files like version and licenses information.

Thanks!

hi @Burtan . yes, we can find way to expose our sourceSet directory to configuration

will be fixed in 0.24.0, please check in 0.24.0-alpha-6

will be available in 0.24.0-beta-1 :)

@Alex009

> Task :core:compileDebugKotlinAndroid FAILED
e: core/build/generated/kotlin/generateMRandroidMain/com/Res.kt:13:17 Object 'strings' is not abstract and does not implement abstract member public abstract val __platformDetails: ResourcePlatformDetails defined in dev.icerock.moko.resources.ResourceContainer
e: core/build/generated/kotlin/generateMRandroidMain/com/Res.kt:259:17 Object 'plurals' is not abstract and does not implement abstract member public abstract val __platformDetails: ResourcePlatformDetails defined in dev.icerock.moko.resources.ResourceContainer
e: core/build/generated/kotlin/generateMRandroidMain/com/Res.kt:263:17 Object 'images' is not abstract and does not implement abstract member public abstract val __platformDetails: ResourcePlatformDetails defined in dev.icerock.moko.resources.ResourceContainer

@ynsok any details? Sorry, but this log is useless

Ok, After updating to 0.24.0-beta-1

multiplatformResources {
    resourcesPackage.set("com.******.********")
    resourcesClassName.set("Res")
}

@ExNDY What other information do you need?

@ynsok that problem has no connection with this issue, please create separate issue. What we need: Versions: kotlin, agp, gradle Structure of resources in project. Because we need something recreate your problem on us project. You send only part of log, generated code file, but if this new generated file i need find why code generated without interface realisation

@ExNDY My Bad, I didn't update the resources Generator version. It is working

Np)

Hey, thanks for addressing this issue! I tried beta-2 with createBuildInfoTask generating resources defined as the tasks output.

afterEvaluate {
    multiplatformResources.resourcesSourceSets["commonMain"].srcDir(createBuildInfoTask)
}

The directory is read correctly and the resource access code is generated. However, the gradle dependency graph is not modified, which means you have to manually trigger the createBuildInfoTask before invoking the moko-resources tasks.

According to JetBrains this should be the way to define task/resource dependencies.

If you know what should be changed to achieve what you want - sent pr :) Or just add Gradle task dependsOn

When using an explicit dependsOn, it often results in complex explicit task dependencies that have to follow (see the linked thread). I have no experience in Gradle plugin coding, but maybe SourceDirectorySet.compiledBy has to be used to tell Gradle that the task processing the resources actually depends on tasks that define the SourceDirectorySet? Maybe the task just has to declare dependency on the SourceDirectorySet?