Icebob comments

Results 390 comments of


                                            Icebob

allow to add metas in the schema

Could you create a PR?

how to write enum types as a short hand ? + enum validation bug

Enum values have no shorthand format.

imp(core): Modify the entry value of the default setting to undefined…

You can overwrite these values as well, just you should reorder the mixins

Missing interface when upload file.

If you upload a file, the `ctx.params` will contain a Node.js `Stream` instance. It works, you can find example code [here](https://github.com/moleculerjs/moleculer-web/blob/master/examples/file/index.js) and [here](https://github.com/moleculerjs/moleculer-web/blob/master/examples/file.service.js#L48-L73). If you think you find an issue,...

Barebone moleculer services with gateway+service

Please resolve conficts

feat(runner): load service by matched path

Could you write an exact example where the original code doesn't load the desired files?

RateLimit didn't check if trusted proxy send the header x-forwarded-for

What is your proposal?

RateLimit didn't check if trusted proxy send the header x-forwarded-for

Ok, but as you see, it's covered, because this logic just a default value, you can overwrite it in `rateLimit` options.

feat(compileRest): allow to reuse the rest settings, to generate rest path from parameters

Good idea, please add relevant tests as well

What is the benefit of using ctx.meta.$location & ctx.meta.$responseType vs just setting via ctx.meta.$responseHeaders?

Nothing special just you can write the same shortly.